Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using $permissions rules without URL part #229

Open
Alex-302 opened this issue Sep 6, 2024 · 2 comments
Open

Allow using $permissions rules without URL part #229

Alex-302 opened this issue Sep 6, 2024 · 2 comments
Assignees
Labels
enhancement Improvement of existent feature Priority: P4

Comments

@Alex-302
Copy link
Member

Alex-302 commented Sep 6, 2024

$permissions=join-ad-interest-group=() can work without URL, and /*/ is redundant (like $removeparam=s_cid).

Related to https://github.com/AdguardTeam/FiltersRegistry/blob/e529458be21800609358ce99ff1bcc8bb5b02305/filters/filter_3_Spyware/diff.txt:

! Error: "The rule is too wide, add domain restriction or make the pattern more specific" in the rule: "*.*$permissions=join-ad-interest-group=()\, run-ad-auction=()\, browsing-topics=()"
*.*$permissions=join-ad-interest-group=()\, run-ad-auction=()\, browsing-topics=()

TODO: remove /*/ in https://github.com/AdguardTeam/AdguardFilters/pull/188049/files after update.

@Alex-302 Alex-302 added the enhancement Improvement of existent feature label Sep 6, 2024
@Alex-302
Copy link
Member Author

@slavaleleka Any news?

@slavaleleka
Copy link
Contributor

no, not even planned to be done in the near future yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existent feature Priority: P4
Projects
None yet
Development

No branches or pull requests

3 participants