Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid runtimes kept in runtime cache #23

Closed
aahlenst opened this issue Nov 7, 2020 · 1 comment
Closed

Invalid runtimes kept in runtime cache #23

aahlenst opened this issue Nov 7, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aahlenst
Copy link
Contributor

aahlenst commented Nov 7, 2020

#22 leaves partially extracted runtimes in the cache. For example, if the Linux archive fails to extract, I end up with the following contents in the runtime cache:

legal
release

As a result, jlinking can produce weird results. If I try to cross target Linux from a Windows JDK, jlink does not find the jmods in the Linux JDK and instead copies the Windows jmods. As a result, I end up with exe and dll files in a jlinked runtime for Linux. This behaviour by jlink is weird in itself, but nevertheless jlink.online should ensure that invalid runtimes do not end up in the cache.

@cilki
Copy link
Member

cilki commented Nov 7, 2020

Agreed. We could additionally ensure the jmods directory exists before passing it to jlink. As you noted, jlink uses the first module it finds, so that must always be the one from the target runtime.

@cilki cilki self-assigned this Nov 7, 2020
@cilki cilki added the bug Something isn't working label Nov 7, 2020
@cilki cilki closed this as completed in dbc57fa Nov 8, 2020
@karianna karianna added this to the November 2020 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants