Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-9492]Adyen Logger is confusing for /connectedTerminals requests on live / production #2737

Open
pmzandbergen opened this issue Sep 9, 2024 · 0 comments
Assignees
Labels
Bug report Indicates that issue has been marked as a possible bug

Comments

@pmzandbergen
Copy link
Contributor

Describe the bug
When the module is on live mode, the Adyen Logger will still log /connectedTerminals requests but the log details are missing. This is caused by the applied filter for live / production requests, added when the logging itself was implemented: #1902

Example on test

[2024-09-05T13:13:15.999381+00:00] AdyenLoggerTest.INFO: Request to Adyen API /connectedTerminals {"apiVersion":"","body":{"merchantAccount":"..."}} {"uid":"2b94b52"}
[2024-09-05T13:13:16.079477+00:00] AdyenLoggerTest.INFO: Response from Adyen API {"body":{"uniqueTerminalIds":["..."]}} {"uid":"2b94b52"}

Example on live / production

[2024-09-05T13:36:27.711069+00:00] AdyenLoggerTest.INFO: Request to Adyen API /connectedTerminals {"apiVersion":"","livePrefix":"...","body":[]} {"uid":"835108d"}
[2024-09-05T13:36:27.759809+00:00] AdyenLoggerTest.INFO: Response from Adyen API {"body":[]} {"uid":"835108d"}

This log record is of course pretty useless.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to production mode
  2. Start a POS (terminal) payment
  3. Check the logs

Expected behavior
Both merchantAccount and uniqueTerminalIds are present in the logs, or nothing is logged at all.

Magento version
2.4.7-p2

Plugin version
9.7.2

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
The log is confusing, it can make you think that there are no terminals active when there actually are.

@pmzandbergen pmzandbergen added the Bug report Indicates that issue has been marked as a possible bug label Sep 9, 2024
@khushboo-singhvi khushboo-singhvi self-assigned this Sep 27, 2024
@khushboo-singhvi khushboo-singhvi changed the title Adyen Logger is confusing for /connectedTerminals requests on live / production [ECP-9492]Adyen Logger is confusing for /connectedTerminals requests on live / production Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Indicates that issue has been marked as a possible bug
Projects
None yet
Development

No branches or pull requests

2 participants