Possible NullReference Exception

[tmacharia]

africastalking.Net/AfricasTalkingCS/AfricasTalkingGateway.cs

Line 398 in 640b195

if (phoneNumber.Length == 0 || shortCode.Length == 0 || keyWord.Length == 0 || !IsPhoneNumber(numbers))

Hi, this check will fail when a string in null since you can't call .Length on a null string object.

I would suggest using String.IsNullOrWhiteSpace(String) to do the check.

You can create a test case wherein you pass null for phoneNumber/shortCode/keyWord and see that a NullObjectReferenceException is thrown instead of the anticipated AfricasTalkingGatewayException

[TheBeachMaster]

Nice catch, would you mind sending a PR with a minor version bump...

[tmacharia]

Let me see.