Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe componentWillReceiveProps lifecycle hook #165

Open
bryszard opened this issue Mar 31, 2019 · 0 comments · May be fixed by #222
Open

Unsafe componentWillReceiveProps lifecycle hook #165

bryszard opened this issue Mar 31, 2019 · 0 comments · May be fixed by #222
Assignees
@jmpainter
Labels
review

Comments

@bryszard
Copy link
Contributor

We're using the lifecycle hook which is considered to be unsafe and will be deprecated in React v17. We should replace it with another solution. Check - https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops for problem description and possible solutions.

Expected Behavior

Components load correctly without using componentWillReceiveProps lifecycle hook.

Current Behavior

We're using componentWillReceiveProps lifecycle hook.

Possible Solution

https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html
@bryszard bryszard changed the title Unsafe componentWillReceiveProps Unsafe componentWillReceiveProps lifecycle hook Mar 31, 2019
@jmpainter jmpainter self-assigned this May 2, 2019
@jmpainter jmpainter linked a pull request May 2, 2019 that will close this issue
Open
@ghost ghost added the review label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmpainter jmpainter

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removing componentWillReceiveProps jmpainter/WebsiteOne-FE
2 participants
@jmpainter @bryszard