Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed decorator functional test failing for nightly #1747

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Fixed decorator functional test failing for nightly #1747

merged 2 commits into from
Aug 16, 2023

Conversation

kessler-frost
Copy link
Member

@kessler-frost kessler-frost commented Aug 15, 2023 •
edited
Loading

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #1747 (45c9730) into develop (a5f5cf9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1747   +/-   ##
========================================
  Coverage    88.20%   88.20%           
========================================
  Files          191      191           
  Lines         8217     8217           
  Branches       151      151           
========================================
  Hits          7248     7248           
  Misses         864      864           
  Partials       105      105
Flag Coverage Δ
Dispatcher 86.68% <ø> (ø)
Functional_Tests 56.25% <ø> (ø)
SDK 91.49% <ø> (ø)
UI_Backend 91.15% <ø> (ø)
UI_Frontend 72.64% <ø> (ø)

@kessler-frost kessler-frost marked this pull request as ready for review August 15, 2023 17:27
@kessler-frost kessler-frost requested a review from a team as a code owner August 15, 2023 17:27
AlejandroEsquivel
AlejandroEsquivel approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@AlejandroEsquivel AlejandroEsquivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kessler-frost !

@AlejandroEsquivel AlejandroEsquivel merged commit eec8d77 into develop Aug 16, 2023
11 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the fix-decorator-test branch August 16, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroEsquivel AlejandroEsquivel AlejandroEsquivel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kessler-frost @AlejandroEsquivel