Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

material classes --> ENVO #35

Open
pbuttigieg opened this issue May 14, 2018 · 3 comments
Open

material classes --> ENVO #35

pbuttigieg opened this issue May 14, 2018 · 3 comments

Comments

@pbuttigieg
Copy link
Contributor

pbuttigieg commented May 14, 2018

Based on our original design of AGRO, several classes in (e.g. liming material, note the issues with multiple inheritance) should be moved into ENVO.

@marieALaporte
Copy link
Member

I am happy to have this class and any other material classes that are not specific to AGRO domain to ENVO.
How should I proceed?

Regarding your comment on multiple inheritance, I realize that this is common in Agro. What is the best practice to fix this issues. If I take the example of this 'liming material' class, we would like to list all (or some) of the elements that are liming materials. Should we be using subsets instead?

@pbuttigieg
Copy link
Contributor Author

I am happy to have this class and any other material classes that are not specific to AGRO domain to ENVO. How should I proceed?

Let's create a term request in ENVO, linking to this thread. Once we have it, you can obsolete the term in AGRO and add a replaced by annotation property on it, pointing to the ENVO term (in CURIE format)

Regarding your comment on multiple inheritance, I realize that this is common in Agro. What is the best practice to fix this issues. If I take the example of this 'liming material' class, we would like to list all (or some) of the elements that are liming materials. Should we be using subsets instead?

Best to create an equivalence axiom like 'liming material' is_a 'environmental material' and 'input of' some 'lime scattering process'. That class be filled by inference, so there won't be asserted multiple inheritance.

@KrishnaTO
Copy link
Contributor

KrishnaTO commented Nov 4, 2021

Assuming you'd like to continue the plan to move terms to ENVO (requesting confirmation @pbuttigieg due to stale issue), need to determine which terms require moving.
For reference: https://www.ebi.ac.uk/ols/ontologies/agro/terms?iri=http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FENVO_00010483

  • List AGRO instantiated classes within environmental material

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants