Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Dicipline Issues #154

Open
CoreAutomation-JD opened this issue Nov 29, 2023 · 3 comments
Open

Is Dicipline Issues #154

CoreAutomation-JD opened this issue Nov 29, 2023 · 3 comments

Comments

@CoreAutomation-JD
Copy link

I've come across several spells that have "Is Discipline" unchecked, but the spell itself says its a combat ability. You have to actually enabled "Is Discipline", then disable in order to fix this.

@Isaaru
Copy link

Isaaru commented Dec 12, 2023

In the database many disciplines are actually flagged -1 instead of 1 for "IsDiscipline". Look at it in SQL or peqeditor to verify.

@Akkadius
Copy link
Owner

Akkadius commented Dec 12, 2023

Looks like there are 3 possible values.

mariadb> select count(*), IsDiscipline from spells_new group by IsDiscipline;
3 rows in set (0.00 sec)
| count(*) | IsDiscipline |
+----------+--------------+
|     1628 |           -1 |
|    39066 |            0 |
|       28 |            1 |
+----------+--------------+
3 rows in set (0.00 sec)

The checkbox looks for 0 (false) / 1 (true)

I'm unsure of the scenarios where it is -1 and why but if anyone knows why we can account for it

@Isaaru
Copy link

Isaaru commented Dec 12, 2023

My recent testing of Disciplines getting overwritten by debuffs led me down a rabbit hole to find out that a discipline MUST be 1 (not -1) in order to be considered a discipline when it comes to stacking exemptions. However, this created other problems. Those issues are unrelated to this but just wanted to add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants