Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When joined game in lobby, cannot leave game. #24

Open
shashwatkansal opened this issue Jul 22, 2021 · 2 comments
Open

When joined game in lobby, cannot leave game. #24

shashwatkansal opened this issue Jul 22, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@shashwatkansal
Copy link
Collaborator

shashwatkansal commented Jul 22, 2021

Cannot leave the lobby since the player is still there. If the player has no already readied up, everyone has to restart a new game. Could be a potential attack as well on the game to prevent players from being able to start a game.

Will require updating player box on the frontend, and removing player from the game instance on the backend.

@shashwatkansal shashwatkansal added bug Something isn't working enhancement New feature or request labels Jul 22, 2021
@Akshat-Tripathi
Copy link
Owner

Maybe we could add a kicked for inactivity?
Or whenever someone disconnects from the lobby, we kick em

@Akshat-Tripathi
Copy link
Owner

Something to consider is that the game assigns countries as soon as you join the lobby, and sends them to everyone, so a deassignment routine would be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants