Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Admin Logout Handling #82

Open
Xevion opened this issue Sep 30, 2024 · 4 comments
Open

Improve Admin Logout Handling #82

Xevion opened this issue Sep 30, 2024 · 4 comments

Comments

@Xevion
Copy link

Xevion commented Sep 30, 2024

Hi, I understand why this integration will continuously log me or anyone else out from the administrative panel of my AX1800's router, but to me, it feels both dangerous and inconvenient that a mere Home Assistant integration can soft-lock a very important capability 24/7.

I would like to push for more improved handling than "just disable the integration prior to logging in".

Here are my concerns:

  • If Home Assistant becomes inaccessible, locks up, or loads slowly - many users will be unable to access their router's panel.
    • While yes, you can just shut down or disconnect the device hosting Home Assistant - doing so remotely is not in every user's power, and might introduce new issues (e.g. the server doesn't start back up on its own).
  • The integration is not exactly straightforward to disable, there's more steps involved to it.
  • The integration does not play nice with forgetful, unaware or any other admins who might be on the network. It's quite a nuisance.

At the very least, I'm just trying to make enabling/disabling the integration super simple (a one-click button/toggle/script), so I can turn it off and be reminded to turn it back on if I forget while adjusting settings.

@AlexandrErohin
Copy link
Owner

@Xevion What is your router hardware version?

@Xevion
Copy link
Author

Xevion commented Oct 1, 2024

@Xevion What is your router hardware version?

Firmware Version: 1.1.4 Build 20230219 rel.69802(5553)
Hardware Version: Archer AX21 v3.0

I'm sure that I'm out of date at this moment, albeit I wouldn't know how it changes anything here.

Edit: I notice the use of AX21 and AX1800, the latter is present in the title of my admin panel's page. I am mildly confused by the terms here.

@MrConorAE
Copy link

Just my two cents; the mobile app for TP-Link prompts before disconnecting other users. Could there be a way of checking for another user being logged in, and cancelling the refresh if there is?

@Xevion
Copy link
Author

Xevion commented Nov 3, 2024

Just my two cents; the mobile app for TP-Link prompts before disconnecting other users. Could there be a way of checking for another user being logged in, and cancelling the refresh if there is?

image

I just tested this, and yeah, it somehow communicates to the UI there an existing session is active. Everything seems encrypted though, the base64 'data' property doesn't decode. My bet though is that this repository already has the pre-requisites necessary to decode, it just doesn't use the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants