-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis Updates: RNA-seq differential-expression module #137
Comments
The current example isn't QN'd data. |
Oh I see that now. Hmm.. I guess I was thrown off by DGEList thing. Why did we choose limma-voom here? |
I do not have a good reason. |
We should look at the examples listed here and decide what we would like to do (or maybe a few of them): https://bioconductor.org/packages/release/bioc/vignettes/tximport/inst/doc/tximport.html#Downstream_DGE_in_Bioconductor I do not understand the rationale of limma-voom vs the various DESEq2 models and I suspect this will also be an area of confusion for our users. So although we don't want to get too far into the weeds on dge models, we should evaluate:
|
I think I remember reading this before, but it's a great little summary to keep in mind for this: https://www.biostars.org/p/284775/ |
Also this by Mike Love: https://mikelove.wordpress.com/2016/09/28/deseq2-or-edger/ |
I don't feel like its super necessary or helpful to keep an example of each edgeR, limma-voom, and DESEq2. So what I think might be a good way forward is to change this example to be DESEq2-centric, but briefly acknowledge the others and link out to examples of those as well as the nice summary articles. Our rationale for choosing DESeq2 would basically be
So the current rna-seq_DGE.RMd notebook we we switch the strategy to DESeq2 so it will be more parallel to the rest of of module changes. Basic steps would be:
|
As discussed with @jaclyn-taroni and @cansavvy in the data science team Slack channel. The changes made in PR #140 seem to be better suited for the differential-expression example notebook. That being said, the current branch in PR #140 (which has been closed, but branch retained) can be merged into a new branch for the purpose of getting started on this ticket. @jaclyn-taroni edit: the branch name is |
Expanding on this point a bit - from #140 (review)
So more generally, I think multiple DGE examples could be very useful where what is on |
I also wanted to note that the dataset currently in use on #140 is also included in one of our exercises for training–I expect that material will also help with getting the DGE example done. |
Since we are trying to integrate more DESeq2 functionality into our RNA-seq section, we should make differential expression reflect that as well since that is its main utility.
We can borrow from training-modules steps: https://github.com/AlexsLemonade/training-modules/blob/master/RNA-seq/05-nb_cell_line_DESeq2.Rmd and maybe useful tidbits from here: https://github.com/AlexsLemonade/training-modules/blob/master/RNA-seq/03-gastric_cancer_exploratory.Rmd
I'm debating about whether we should still maintain a QN'ed from refinebio version of differential-expression? One strategy is we could keep the current example but reframe it as a "pre-normalized DE" example and make the new notebook a "starting at counts DE" example. Thoughts?The text was updated successfully, but these errors were encountered: