Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Modernize" the reshape2::melt step in the microarray gene id conversion notebook #224

Closed
cansavvy opened this issue Sep 22, 2020 · 2 comments · Fixed by #230
Closed

"Modernize" the reshape2::melt step in the microarray gene id conversion notebook #224

cansavvy opened this issue Sep 22, 2020 · 2 comments · Fixed by #230
Assignees

Comments

@cansavvy
Copy link
Contributor

cansavvy commented Sep 22, 2020

It looks like reshape2 is used by gene-id-annotation_microarray_01_ensembl.Rmd but was not added to the Dockerfile and image in that PR: #212 .

Unless you install the reshape2 package on your Docker container, snakemake will not successfully run. Apparently only reshape is included in the tidyverse set of packages?

- `if` install step should be added to this Rmd for the users purposes. - `reshape2` should be added to the Dockerfile. - The Docker image should be rebuilt from that Dockerfile and pushed to dockerhub.

Update :

We should use the strategy used in the RNA-seq gene id conversion notebook in the microarray notebook :

reshape2::melt(value.name = "Symbol") %>%

@jaclyn-taroni
Copy link
Member

Is this an opportunity to modernize instead? #218 (comment)

@cansavvy
Copy link
Contributor Author

Is this an opportunity to modernize instead? #218 (comment)

Ah yes. Even better. Let's do that to the microarray analysis notebook than too. Will change the title of this issue.

@cansavvy cansavvy changed the title Reshape2 needs to be added to the Dockerfile and image "Modernize" the reshape2::melt step in the microarray gene id conversion notebook Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants