Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORA upset plot is not saved, only enrich plot 2x! #393

Closed
cansavvy opened this issue Dec 1, 2020 · 1 comment
Closed

ORA upset plot is not saved, only enrich plot 2x! #393

cansavvy opened this issue Dec 1, 2020 · 1 comment

Comments

@cansavvy
Copy link
Contributor

cansavvy commented Dec 1, 2020

Background

@envest identified this in the RNA-seq version but it will need to be fixed in the microarray version too.
#381 (comment)

Problem

The upset plot is not saved thought it looks like it's being saved! It's actually the enrich_plot twice! Whoops.

What potential "gotchas" do we know of?

Change needs to occur in both staging and master. Depending on timing, this might be a hotfix or might be able to be slid in with #391 or #390 or by itself
@cansavvy cansavvy mentioned this issue Dec 1, 2020
Merged
10 tasks
@cansavvy
Copy link
Contributor Author

cansavvy commented Dec 1, 2020

This was addressed in #394

@cansavvy cansavvy closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cansavvy