Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix publish workflow #7

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

pgarrison
Copy link
Contributor

Two changes here:

  1. Try again to fix the PyPi publish action (following the pattern used in aics-shparam)
  2. Remove old python versions from the test matrix because they were failing

@pgarrison pgarrison changed the title Bugfix/publish workflow Attempt to fix publish workflow Aug 2, 2023
Copy link

@amilworks amilworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a GitHub action or step that performs a dry run that checks if everything works?

@pgarrison
Copy link
Contributor Author

Do you have a GitHub action or step that performs a dry run that checks if everything works?

@amilworks No, the issue is in the integration between (our configuration of) the PyPi publishing action and PyPi, and the PyPi publishing action doesn't appear to have a dry-run mode.

@pgarrison pgarrison merged commit 923f977 into master Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants