From 3dc5f2e0ad5ed396bc209743045ca49b31195405 Mon Sep 17 00:00:00 2001 From: David-Emmanuel DIVERNOIS Date: Wed, 4 Dec 2024 14:28:57 +0100 Subject: [PATCH 1/2] Fix release workflow --- .github/workflows/release.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fefb367..89f381a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -24,13 +24,8 @@ jobs: - run: | git config --global user.name github-actions git config --global user.email github-actions@github.com - - name: npm version - if: inputs.version != 'doconly' - run: | - npm version ${{ inputs.version }} - git add package.json package-lock.json - git commit -m v${{ inputs.version }} - git tag v${{ inputs.version }} + - if: inputs.version != 'doconly' + run: npm version ${{ inputs.version }} - run: git show HEAD - run: npm run build - run: npm run docs From 531a3ce409f5d9636e2457431aae7014454eb66a Mon Sep 17 00:00:00 2001 From: David-Emmanuel DIVERNOIS Date: Wed, 4 Dec 2024 14:54:34 +0100 Subject: [PATCH 2/2] Call makeGraph from setup in dynamic bench test --- benchmarks/js-reactivity-benchmarks/dynamic.bench.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/benchmarks/js-reactivity-benchmarks/dynamic.bench.ts b/benchmarks/js-reactivity-benchmarks/dynamic.bench.ts index 536f0f3..2bf09b2 100644 --- a/benchmarks/js-reactivity-benchmarks/dynamic.bench.ts +++ b/benchmarks/js-reactivity-benchmarks/dynamic.bench.ts @@ -307,11 +307,12 @@ const perfTests = [ ]; for (const config of perfTests) { - const { graph, counter } = makeGraph(config); + let graphAndCounter: GraphAndCounter; bench( `dynamic ${config.name}`, () => { + const { graph, counter } = graphAndCounter; counter.count = 0; const sum = runGraph(graph, config.iterations, config.readFraction); @@ -322,6 +323,13 @@ for (const config of perfTests) { expect(counter.count).toBe(config.expected.count); } }, - { throws: true, setup } + { + throws: true, + time: 5000, + setup() { + graphAndCounter = makeGraph(config); + setup(); + }, + } ); }