-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some small comments regarding Code Structure and Code Formatting #3
Comments
Thank you @AKuederle for these suggestions. I have a few questions to make sure I grasp this correctly:
In the beginning, define the path like this: from pathlib import Path
pp = "P25"
path = Path("COPY-YOUR-ADDRESS-HERE")
conditions = ['sitting', 'arithmetic', 'recovery']
devices = ["kyto", "empatica", "vu"]
criterion = "vu" Then, I also need modify the functions slightly to incorporate this. For instance, in the Is this what you are suggesting to be done? |
Regarding the path thing: I would usggest to use |
Regarding huge files: While this is a matter of preference, most people structure their functions in multiple smaller files based on categories (e.g. plotting, utils, io, loading, stats, ...). And then depending on the project, the relevant methods are reexported in user facing files to separate the internal structure from the import structures for users. For example see scikit-learn: https://github.com/scikit-learn/scikit-learn/tree/main/sklearn/cluster Here the implementaiton is split in smaller files to easier find things, but then user facing functions are re-imported in the top-level init to provide more convenient import syntax |
|
Overall the code quality looks great, but here are a couple of smaller things that could be improved:
Path
instead of strings for file/folder paths -> This will solve a bunch of issues caused by the differences between operating systems. For example it would make.replace('\\', '/')
obsolote in the exampleindividual
file)ruff
orblack
The text was updated successfully, but these errors were encountered: