Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question_series in Base #1094

Closed
albertas-jn opened this issue Jun 11, 2024 · 2 comments
Closed

question_series in Base #1094

albertas-jn opened this issue Jun 11, 2024 · 2 comments
Assignees

Comments

@albertas-jn
Copy link
Contributor

Think about if question_series should be defined in Base. It adds question series to experiments that don't need to ask any questions (Toontjehoger). Otherwise, assign question_series=[] in extended classes.

@albertas-jn albertas-jn self-assigned this Jun 19, 2024
@BeritJanssen BeritJanssen self-assigned this Jun 26, 2024
@BeritJanssen
Copy link
Collaborator

I included a commit to remove the question_series from base.py while working on #847. I need to go over all rules files for that issue, in order to check which session methods they call, and it kind of itched in my fingers to go ahead and remove it.

@albertas-jn
Copy link
Contributor Author

OK, but it should not be completely removed, but set to an empty list. I'd also keep the current question_series as a comment/doc in the file just as an example how it can be done if base.py is ever used as a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants