Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in variable inside sync_template.sh #267

Closed
LuisHenri opened this issue Dec 30, 2022 · 2 comments · Fixed by #268 or #269
Closed

Typo in variable inside sync_template.sh #267

LuisHenri opened this issue Dec 30, 2022 · 2 comments · Fixed by #268 or #269
Labels
bug Something isn't working

Comments

@LuisHenri
Copy link
Contributor

Describe the bug
Seems like I forgot to change some variable names on my last PR (sorry).

To Reproduce
Steps to reproduce the behavior:

  1. Go to sync_template.sh

Expected behavior
It should be TEMPLATE_SYNC_IGNORE_FILE_PATH instead of TEMPLATE_SYNC_IGNORE_FILE_NAME

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
Regarding PR #252
@LuisHenri LuisHenri mentioned this issue Dec 30, 2022
Merged
@AndreasAugustin
Copy link
Owner

Thanks for the fix. Seems I did not careful check last PR :)
I will think about adding a test for this case.

@AndreasAugustin AndreasAugustin added the bug Something isn't working label Dec 30, 2022
@LuisHenri LuisHenri mentioned this issue Dec 30, 2022
Merged
@LuisHenri
Copy link
Contributor Author

@AndreasAugustin I also just forgot to change the IF order (sorry again)
#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@AndreasAugustin @LuisHenri