Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Overwrite open PR #482

Closed
1 task
kdeldycke opened this issue Mar 3, 2024 · 2 comments · Fixed by #499
Closed
1 task

[Feat]: Overwrite open PR #482

kdeldycke opened this issue Mar 3, 2024 · 2 comments · Fixed by #499
Assignees
Labels
enhancement New feature or request

Comments

@kdeldycke
Copy link
Contributor

Describe the feature

I'd like to have a way to tell actions-template-sync it is okay to overwrite an existing PR.

This might solve issue #481, but also goes beyond that, as it will reset the commits attached to that PR and force a push.

Use Case

I want my workflows based on actions-template-sync to have authority on the PR it creates, but also gives actions-template-sync the permission to scrap any changes added after its run.

It will also address some edge-cases I stumble into while experimenting in the context #467, where my PR is stuck because actions-template-sync is not capable of getting over some merge conflicts (see #476).

Proposed Solution

No response

Acknowledgements

  • I may be able to implement this feature request
@AndreasAugustin AndreasAugustin added the enhancement New feature or request label Mar 5, 2024
AndreasAugustin added a commit that referenced this issue Mar 13, 2024
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
AndreasAugustin added a commit that referenced this issue Mar 13, 2024
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
AndreasAugustin added a commit that referenced this issue Mar 13, 2024
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
@AndreasAugustin
Copy link
Owner

AndreasAugustin commented Mar 13, 2024

Hi @kdeldycke and thanks for your patience.
With #499 you have the option to force push PRs. Please note that you also need to add more permissions for the workflow (repository-projects: read)

  permissions:
    contents: write
    pull-requests: write
    repository-projects: read

Documented here https://github.com/AndreasAugustin/actions-template-sync#force-push-and-pr
This will also close #481 . Decided to have the option to opt in to this feature (not forcing per default).

Will be available in v1.12.0

AndreasAugustin added a commit that referenced this issue Mar 13, 2024
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
@AndreasAugustin AndreasAugustin self-assigned this Mar 13, 2024
@kdeldycke
Copy link
Contributor Author

Can confirm this is working! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants