-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: when cleaning up PRs with is_pr_cleanup: true, switches to main on PR cleanup #529
Comments
that is weird. Need to check it. Thanks for the report! Update: Will try to provide a fix asap. Remark |
@all-contributors please add @kanno41 for bug |
I've put up a pull request to add @kanno41! 🎉 |
@kanno41 I think I understand the issue now. It is somehow an edge case.
As a intermediate mitigation action you can remove the For a bug fix I need to think about some options:
currently I need to think about the downsides of each option. |
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
@kanno41 #534 should fix this issue. I need to test it. You can try the solution with - name: actions-template-sync
# use here the related branch name
uses: AndreasAugustin/actions-template-sync@#529
with:
source_repo_path: <owner/repo>
upstream_branch: <target_branch> # defaults to main
pr_labels: <label1>,<label2>[,...] # defaults to template_sync
is_force_push_pr: true
is_pr_cleanup: true It actually checks if the remote branch equals the local branch. If so, it skips the cleanup for that branch. |
Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
…e-sync into fix/#529 Signed-off-by: Andy Augustin <dev@andreas-augustin.org>
Is there an existing issue for this?
Describe the bug
I had an old PR existing and tried to have it clean up the old PR. However, when it cleaned up the PR, it switched the branch to main. I am using a GitHub App.
Expected Behavior
PR should be created from created chore branch
Current Behavior
See Description
Steps To Reproduce
No response
Possible Solution
unsure, theoretically
is_keep_branch_on_pr_cleanup: true
should work for me, but it is also has a bug (#528)Additional Information/Context
I am using
is_force_push_pr: true
. I don't really want to force push, I want to delete the branch first in all cases (which is essentially a force push, I suppose).Template sync version Version
2.2.0
The text was updated successfully, but these errors were encountered: