Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Add the name of the .templatesyncignore file as a parameter #567

Closed
1 task done
TechnicallyJoe opened this issue Oct 14, 2024 · 3 comments · Fixed by #568
Closed
1 task done

[Feat]: Add the name of the .templatesyncignore file as a parameter #567

TechnicallyJoe opened this issue Oct 14, 2024 · 3 comments · Fixed by #568
Assignees
@AndreasAugustin
Labels
enhancement New feature or request

Comments

@TechnicallyJoe
Copy link
Contributor

Describe the feature

Add the name/path of the .templatesyncignore file as a parameter to the action. Default to .templatesyncignore for backwards compatibility.

Use Case

We're looking into a use case where it would be nice to be able to sync from 2 different repositories but they need their own .templatesyncignore file defined.

Proposed Solution

No response

Acknowledgements

  • I may be able to implement this feature request
@TechnicallyJoe TechnicallyJoe mentioned this issue Oct 14, 2024
Merged
@AndreasAugustin AndreasAugustin self-assigned this Oct 14, 2024
@AndreasAugustin AndreasAugustin added the enhancement New feature or request label Oct 14, 2024
@AndreasAugustin
Copy link
Owner

Hi @TechnicallyJoe and thanks a bunch for your feature request.
I understand the use case and think it is useful.

Also thanks a lot for the PR #568 I will have a look into it.

@AndreasAugustin
Copy link
Owner

@all-contributors please add @TechnicallyJoe for ideas and code

@allcontributors allcontributors bot mentioned this issue Oct 14, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@AndreasAugustin

I've put up a pull request to add @TechnicallyJoe! 🎉

@AndreasAugustin AndreasAugustin moved this from To do to Review in progress in actions-template-sync Oct 14, 2024
AndreasAugustin added a commit that referenced this issue Oct 15, 2024
@TechnicallyJoe @AndreasAugustin
feat(#567): Add the name of the .templatesyncignore file as a paramet…
03661a8 
…er (#568)


---------

Signed-off-by: Jonathan Østrup <7877957+TechnicallyJoe@users.noreply.github.com>
Co-authored-by: andy Augustin <AndreasAugustin@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Review in progress to Done in actions-template-sync Oct 15, 2024
@github-actions github-actions bot mentioned this issue Oct 15, 2024
Merged
@github-actions github-actions bot mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreasAugustin AndreasAugustin

Labels
enhancement New feature or request
Projects
actions-template-sync
Status: Done
Milestone
No milestone
2 participants
@TechnicallyJoe @AndreasAugustin