[Bug]: No longer works with default push settings

[icco]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Starting with 2.3, the following config fails:

name: template sync
on:
  # run every day at midnight
  schedule:
    - cron: '0 0 * * *'
  # manually trigger the workflow
  workflow_dispatch:
jobs:
  repo-sync:
    runs-on: ubuntu-latest
    permissions:
      contents: write
      pull-requests: write
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          token: ${{ secrets.INFRA_SYNC_TOKEN }}
      - name: actions-template-sync
        uses: AndreasAugustin/actions-template-sync@v2
        with:
          github_token: ${{ secrets.INFRA_SYNC_TOKEN }}
          source_repo_path: "pinginc/template-infra"
          source_repo_ssh_private_key: ${{ secrets.INFRA_TEMPLATE_SYNC_TOKEN }}
          is_pr_cleanup: true

Expected Behavior

I expected this to work as it did in 2.2.3

Current Behavior

The error that occurs is:

  ::info::push changes
  error: src refspec origin does not match any
  error: failed to push some refs to ' --set-upstream'

Steps To Reproduce

Any configuration that does not end up with additional flags for git push

Possible Solution

Rewrite the function at

actions-template-sync/src/sync_template.sh

Lines 290 to 309 in 7cd796f

	function push () {
	info "push changes"
	local branch=$1
	local is_force=$2
	local is_with_tags=$3
	local additional_params=" "
	if [ "$is_force" == true ] ; then
	warn "forcing the push."
	additional_params="${additional_params}--force "
	fi
	if [ "$is_with_tags" == true ] ; then
	warn "include tags."
	additional_params="${additional_params}--tags "
	fi
	git push "${additional_params}"--set-upstream origin "${branch}"
	}

Additional Information/Context

No response

Template sync version Version

2.4.0

[icco]

Created #574 to fix

[AndreasAugustin]

Hi @icco and thanks a lot for the report and the PR!
Will look ASAP into it

[hdesai-dave]

we are also blocked by this

[AndreasAugustin]

we are also blocked by this

@hdesai-dave

🎁

you can always temp mitigate the issue with pining the issue to the last working version. E.g.

      - name: actions-template-sync
        uses: AndreasAugustin/actions-template-sync@v2.2.3
        with:

[AndreasAugustin]

Like @icco already mentioned within the description this change is responsible:
01f7623#diff-2c34df082012b54923698ceb27ff084102dc0cbe7f71ce907b4a8ba41657c6edL289

[AndreasAugustin]

further PR with a test improvement #577

[AndreasAugustin]

@icco thanks a lot for your PR. The issue should be solved with new version v2.4.1