Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation via back button leak #22

Open
jcyu0208 opened this issue Jun 19, 2018 · 1 comment
Open

Navigation via back button leak #22

jcyu0208 opened this issue Jun 19, 2018 · 1 comment

Comments

@jcyu0208
Copy link

In your RouterImp, you store a Dictionary of completions with the ViewController as the key. I think that there is a potential leak here.

The leak will occur when you're using a Navigation Bar's back button instead of programmatically popping the view controller. The Router's dictionary still maintains a reference to the view controller because the back button is not hooked to the router.

@chosa91
Copy link

chosa91 commented Oct 12, 2018

@jcyu0208 You can use something like this:
NavigationControllerObserver - gist
Connecting article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants