Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frankenui Improvement Tasks #13

Open
3 of 11 tasks
Isaac-Flath opened this issue Oct 21, 2024 · 0 comments
Open
3 of 11 tasks

Frankenui Improvement Tasks #13

Isaac-Flath opened this issue Oct 21, 2024 · 0 comments

Comments

@Isaac-Flath
Copy link
Collaborator

Isaac-Flath commented Oct 21, 2024

API Design:

  • Start with type of container then direction. For example instead of LAlignedDiv use DivLAligned. This enables better discoverability because you can consistently start with Div and use tab to see the options rather than remembering the direction (ie does it start with LA or LeftA?). For directions, will match tailwind abbreviations for consistency.
  • Responsiveness is kind of annoying. For the elements that are most likely to need responsiveness tweaks (like Grid) have ncols, ncols_sm, ncols_md to make responsiveness easier.
  • I think Grid should have a small default gap. I think it's pretty rare you want 0 gap in a grid, so may as well have a default there.
  • Verify the *args things are good and match. For example if the signature has *li in it, it should take Li's and children. For example NavContainer (*li, cls=<NavT.primary: 'uk-nav-primary'>, parent=True, uk_nav=False, **kwargs) should take Li stuff and all Li stuff should start with Li, for example NavHeaderLi should be LiNavHeader for better discoverability. *c is used when it can take anything.
  • For LabelInput instead of using for, maybe put the Input inside the label maybe.
  • UkIconLink icon sizes do not play nicely because the icon increases in size but that does not impact the container it's in. When using UkIconLink the height/width needs to be translated to tailwind size and passed to the container.
  • You can select theme color, but not light vs dark. Add that option.

New features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant