Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refering to biomes that are organized inside folders #382

Open
FlamesEC opened this issue Aug 9, 2021 · 6 comments
Open

Refering to biomes that are organized inside folders #382

FlamesEC opened this issue Aug 9, 2021 · 6 comments
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: bug This is a problem in the current implementation type: question This is more a question than an issue version: 1.16 version: 1.17 version: 1.18

Comments

@FlamesEC
Copy link

FlamesEC commented Aug 9, 2021

Hello :D

Im trying to set a tile map to a biome that is created by a datapack... but that biome is inside a folder

BIOMES
|_FOLDER
|__OTHER_FOLDER
|___BIOME_NAME

How would I refer to BIOME_NAME? Would I call the file FOLDER/OTHER_FOLDER/BIOME_NAME.json? Because that does not seem to work

thanks a bunch :D

@tyra314
Copy link
Member

tyra314 commented Aug 9, 2021

Use, whatever the debug screen is saying as biome:

grafik

And put that under assets/<modid>/atlas/tiles/<biome>.json, where <modid> is the name up to the colon : and <biome> is the name after the colon.

@tyra314
Copy link
Member

tyra314 commented Aug 9, 2021

So for the biome in the screenshot, you would need to create a file assets/terralith/atlas/tiles/siberian_taiga.json

@tyra314 tyra314 added the type: question This is more a question than an issue label Aug 9, 2021
@FlamesEC
Copy link
Author

What if it says in there

datapack:FOLDER/OTHER_FOLDER/BIOME_NAME?

@tyra314
Copy link
Member

tyra314 commented Aug 10, 2021

Oh no.

Try FOLDER/OTHER_FOLDER/BIOME_NAME.json as the literal filename inside the folder assets/DATAPACK/atlas/tiles/. It may work.

@FlamesEC
Copy link
Author

FlamesEC commented Aug 10, 2021

I have it like that, just making sure I have the resource pack is set up right
resourcepacks > PACK_NAME > assets > DATAPACK > atlas > tiles > FOLDER/OTHER_FOLDER/BIOME_NAME.json

(This doesnt work btw)

@tyra314 tyra314 added the type: bug This is a problem in the current implementation label Nov 13, 2021
@tyra314 tyra314 added mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version version: 1.16 version: 1.17 labels Dec 20, 2021
@tyra314
Copy link
Member

tyra314 commented Jan 8, 2023

I had the ResourceLoader class in my hands again lately. In contrast to what I said earlier, I now believe it should just work with the correct folder structure, so something like assets/<modid>/atlas/tiles/<folder>/<subfolder>/<biome>.json with each / denoting a new folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: bug This is a problem in the current implementation type: question This is more a question than an issue version: 1.16 version: 1.17 version: 1.18
Projects
None yet
Development

No branches or pull requests

2 participants