Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken rendering with Iris when shaders are enabled #416

Open
Nik-mmzd opened this issue Dec 19, 2021 · 7 comments
Open

Broken rendering with Iris when shaders are enabled #416

Nik-mmzd opened this issue Dec 19, 2021 · 7 comments
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: bug This is a problem in the current implementation version: 1.18

Comments

@Nik-mmzd
Copy link

Nik-mmzd commented Dec 19, 2021

Describe the bug
Atlas rendering bug (see screenshots)

To Reproduce
Compile for 1.18.1 from 37038a3
Install Sodium and Iris
Enable shaders (e. g. BSL)

Expected behavior
image
image

Screenshots
image
image

Fabric version information:

  • Minecraft: 1.18.1
  • Fabric Loader: 0.12.12
  • Fabric API: 0.44.0+1.18
  • AntiqueAtlas: built from commit 37038a3

Additional context
When Iris is installed, but no shaders are enabled, all renders normally
Sodium: 0.4.0-alpha5 (latest)
Iris: 1.1.3 (latest)

@tyra314 tyra314 changed the title 1.18: broken rendering with Iris when shaders are enabled Broken rendering with Iris when shaders are enabled Dec 20, 2021
@tyra314 tyra314 added type: bug This is a problem in the current implementation mod loader: fabric This affects the fabric version version: 1.18 labels Dec 20, 2021
@tyra314
Copy link
Member

tyra314 commented Sep 17, 2022

Does this also happen with the release version?

@pikasalt
Copy link

Yes, I can confirm that this happens using the latest 1.18.2 release versions of iris, sodium, and antique atlas

@tyra314
Copy link
Member

tyra314 commented Oct 17, 2022

According to #448 it also happens on forge

LangYueMc added a commit to LangYueMc/AntiqueAtlas that referenced this issue Nov 26, 2022
@ShiroYatagami
Copy link

Still a problem on iris 1.4.3, sodium 0.4.1 build 15 & indium 1.0.7 when using shaders but not when disabling shaders.

tyra314 pushed a commit that referenced this issue Jan 8, 2023
@tyra314
Copy link
Member

tyra314 commented Jan 8, 2023

Fixed in 99330bd thanks to @LangYueMc

@tyra314 tyra314 closed this as completed Jan 8, 2023
@tyra314 tyra314 reopened this Jan 15, 2023
@tyra314
Copy link
Member

tyra314 commented Jan 15, 2023

Turns out, those patches don't resolve the issue properly.

tyra314 added a commit that referenced this issue Jan 15, 2023
This reverts commit 99330bd.

Neither this commit alone, nor the follow-up commit solves the problem.
It feels like a work-around and I haven't even understood the underlying
problem yet. So I'm going to revert it for now.
kallmetony pushed a commit to kallmetony/AntiqueAtlasReborn that referenced this issue Dec 25, 2023
kallmetony pushed a commit to kallmetony/AntiqueAtlasReborn that referenced this issue Dec 25, 2023
This reverts commit 99330bd.

Neither this commit alone, nor the follow-up commit solves the problem.
It feels like a work-around and I haven't even understood the underlying
problem yet. So I'm going to revert it for now.
@Orgamorsh
Copy link

Orgamorsh commented Jun 9, 2024

I made a resource pack that kinda band-aid fixes this. The issue is with pixels with mixed transparency values overwriting other ones. This resource pack makes every pixel have 255 opacity. I think it works pretty well. I tested it with oculus on complementary.

Antique Atlas Shader Patch.zip

Screenshot 2024-06-09 142902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod loader: fabric This affects the fabric version mod loader: forge This affects the Forge version type: bug This is a problem in the current implementation version: 1.18
Projects
None yet
Development

No branches or pull requests

5 participants