add SC election to proposal monitor #212
Conversation
|
hrm the GovernorExecuteStage status checker needs to wait for the vetting period to be over before executing for the nominee gov.. |
src-ts/proposalStage.ts
Outdated
| @@ -131,6 +133,124 @@ export enum ProposalStageStatus { | |||
| TERMINATED = 4, | |||
| } | |||
|
|
|||
| export class GovernorExecuteStage implements ProposalStage { | |||
There was a problem hiding this comment.
Is this different from the governor queue stage? Cant we just use that?
There was a problem hiding this comment.
The nominee and member election have no timelock, so the execute method is different (and something needs to be done about status w/r/t/ vetting period)
There was a problem hiding this comment.
thinking maybe having a single GovernorExecuteStage that determines the governor type (timelock, no timelock + vetting period, no timelock + no vetting period) and handles status/execute accordingly is cleanest?
There was a problem hiding this comment.
oh also getExecuteReceipt is different (looks for ProposalExecuted vs. CallScheduled).
There was a problem hiding this comment.
Ok, can we base class this then and override where there are differences?
No description provided.