Skip to content

Commit

Permalink
Fixed an issue with KuboBootstrapper not starting on Linux
Browse files Browse the repository at this point in the history
  • Loading branch information
Arlodotexe committed Nov 14, 2023
1 parent bddba28 commit 59b3513
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/KuboBootstrapper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ private Task SetExecutablePermissionsForBinary(SystemFile file)
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
return Task.CompletedTask;

return RunAsync(new SystemFile("/bin/bash"), $"-c \"chmod 777 {file}\"", throwOnError: true);
return RunAsync(new SystemFile("/bin/bash"), $"-c \"chmod 777 {file.Path}\"", throwOnError: true);
}

private async Task RunAsync(SystemFile file, string arguments, bool throwOnError, CancellationToken cancellationToken = default)

Check warning on line 180 in src/KuboBootstrapper.cs

View workflow job for this annotation

GitHub Actions / build

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 180 in src/KuboBootstrapper.cs

View workflow job for this annotation

GitHub Actions / build-and-publish

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Expand Down
6 changes: 5 additions & 1 deletion src/OwlCore.Kubo.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,17 @@
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>

<Author>Arlo Godfrey</Author>
<Version>0.13.0</Version>
<Version>0.13.1</Version>
<Product>OwlCore</Product>
<Description>
An essential toolkit for Kubo, IPFS and the distributed web.
</Description>
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<PackageReleaseNotes>
--- 0.13.1 ---
[Fixed]
Fixed an issue with KuboBootstrapper not starting on Linux.

--- 0.13.0 ---
[New]
Added IGetCid and StorableKuboExtensions.GetCidAsync() for easier content comparison. Enables returning the CID for any IStorable item, falling back to stream hashing for files when IGetCid isn't implemented.
Expand Down

0 comments on commit 59b3513

Please sign in to comment.