Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we can upgrade datafusion to a version that can pass CI? #792

Open
zhuliquan opened this issue Nov 25, 2024 · 2 comments
Open

Maybe we can upgrade datafusion to a version that can pass CI? #792

zhuliquan opened this issue Nov 25, 2024 · 2 comments

Comments

@zhuliquan
Copy link
Contributor

Hello, I notice that arroyo upgrade datafusion to 43.0.0. But Arroyo datafusion doesn't pass CI, is't ok? Perhaps,we can upgrade datafision version which can pass CI.

@mwylde
Copy link
Member

mwylde commented Nov 25, 2024

Are you referring to our fork https://github.com/ArroyoSystems/arrow-datafusion/tree/43.0.0/arroyo?

Unfortunately CI doesn't pass there because it requires access to apache CI resources. It's probably possible to get the CI in a better state but hasn't been a priority.

@zhuliquan
Copy link
Contributor Author

zhuliquan commented Nov 26, 2024

Are you referring to our fork https://github.com/ArroyoSystems/arrow-datafusion/tree/43.0.0/arroyo?

Unfortunately CI doesn't pass there because it requires access to apache CI resources. It's probably possible to get the CI in a better state but hasn't been a priority.

Yeah, I refer it. But I looked at the following errors in the CI because there is the trait with a function that is not implemented. Is there something wrong with this?

error[E0046]: not all trait items implemented, missing: `reset`
   --> datafusion/ffi/src/execution_plan.rs:314:5
    |
314 |     impl ExecutionPlan for EmptyExec {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
    |
    = help: implement the missing item: `fn reset(&self) -> std::result::Result<(), datafusion::error::DataFusionError> { todo!() }`

error[E0046]: not all trait items implemented, missing: `reset`
  --> datafusion-examples/examples/composed_extension_codec.rs:99:1
   |
99 | impl ExecutionPlan for ParentExec {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
   |
   = help: implement the missing item: `fn reset(&self) -> Result<(), datafusion_common::DataFusionError> { todo!() }`

error[E0046]: not all trait items implemented, missing: `reset`
   --> datafusion-examples/examples/composed_extension_codec.rs:175:1
    |
175 | impl ExecutionPlan for ChildExec {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `reset` in implementation
    |
    = help: implement the missing item: `fn reset(&self) -> Result<(), datafusion_common::DataFusionError> { todo!() }`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants