Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework point data management #9

Open
Failxxx opened this issue Sep 2, 2022 · 2 comments
Open

Rework point data management #9

Failxxx opened this issue Sep 2, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Failxxx
Copy link
Collaborator

Failxxx commented Sep 2, 2022

Description

I don't think we need to have different ways to import point data as vertex colors (remap options).
Indeed, we could simply use the 'Map Range' node remap values.

Links to documentation, examples or class definitions

Here is an example:
Left, use of the 'Map Range' node with a 'LOCAL' method for remapping, with values [-0.3978, 0.3978].
Right, 'CUSTOM' method for remapping [0.1, 0.3].
This difference is probably due to a first remap operation when using 'LOCAL' method (see next screenshot).

Screenshot from 2022-09-02 11-13-11

Screenshot from 2022-09-02 11-15-06

Pseudocode or screenshots

Totally remove the 'method' option?

@Failxxx Failxxx added the enhancement New feature or request label Sep 2, 2022
@Failxxx Failxxx self-assigned this Sep 2, 2022
@Failxxx
Copy link
Collaborator Author

Failxxx commented Sep 2, 2022

Also, vertex_colors is deprecated since 3.2. Would probably be nice to use color_attributes now.
See:

@Failxxx
Copy link
Collaborator Author

Failxxx commented Sep 2, 2022

However, it does not seem possible to store point data which values are not in [0, 1] as the documentation says: https://docs.blender.org/api/3.1/bpy.types.MeshLoopColor.html#bpy.types.MeshLoopColor

Thus, it could be difficult to implement this for Blender versions < 3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant