Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Replacing #122: New README (with Chromium Fix) and GUI Stub #124

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

MDNich
Copy link

@MDNich MDNich commented Aug 4, 2022

Hey everyone,

Thanks for everything; I incorporated the suggestion on the chromium in the README, and I created a GUI Stub, with a UI like the following:
Screen Shot 2022-08-04 at 19 51 31

Please let me know whether this is along the lines you all were thinking of, or if you want something completely different (I'm open to anything, using storyboard).

MDNich and others added 15 commits July 30, 2022 18:23
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
I could've sworn I fixed this before, but it must've slipped...

Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
Signed-off-by: Astro Kid <71262643+MDNich@users.noreply.github.com>
@andy9a9
Copy link
Contributor

andy9a9 commented Aug 5, 2022

Binary files like .DS_Store, .xcuserstate have to be excluded

@MDNich
Copy link
Author

MDNich commented Aug 5, 2022

Ok I removed the binary files, what are your thoughts on the initial GUI design? @andy9a9

@andy9a9
Copy link
Contributor

andy9a9 commented Aug 5, 2022

Ok I removed the binary files, what are your thoughts on the initial GUI design? @andy9a9

Some binary files like xuserdatad are still there.

  • Is the initial GUI design something new, or is there something already?
  • Squash some commits like update Readme

@MDNich
Copy link
Author

MDNich commented Aug 5, 2022

Ok I will remove the remaining ones; some of them are necessary for Xcode to work properly though, so I think they may have to stay.

For the GUI, I did not see any other attempts to make one, so this is my own design. I was wondering whether you guys liked the design so I could keep working on it, or if you would like a different kind of GUI so I could implement that instead.

Thank you so much,

MDNich

@MDNich
Copy link
Author

MDNich commented Aug 5, 2022

Some binary files like xuserdatad are still there.

xcuserdatad is not a binary file; its a folder with a plist inside (probably an Xcode internal thing).

@MDNich
Copy link
Author

MDNich commented Aug 5, 2022

I am also not sure how to squash commits; on the merge with Asahi-installer:main you can choose to squash and merge, but I do not think I can do that. Github won't let me sign in to cli git.

@andy9a9
Copy link
Contributor

andy9a9 commented Aug 5, 2022

I am also not sure how to squash commits; on the merge with Asahi-installer:main you can choose to squash and merge, but I do not think I can do that. Github won't let me sign in to cli git.

git rebase -i and fixup and force push are your friends ;) https://medium.com/@slamflipstrom/a-beginners-guide-to-squashing-commits-with-git-rebase-8185cf6e62ec

@marcan marcan force-pushed the main branch 2 times, most recently from f7abb88 to 04c037a Compare June 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants