Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website should receive instead of subclassing Configuration #444

Closed
chadwhitacre opened this issue Jun 18, 2015 · 4 comments
Closed

Website should receive instead of subclassing Configuration #444

chadwhitacre opened this issue Jun 18, 2015 · 4 comments

Comments

@chadwhitacre
Copy link
Contributor

Reticketed from #441.
This was referenced Jun 18, 2015
Open
Closed
Closed
@pjz
Copy link
Contributor

pjz commented Jun 18, 2015

Agreed. IMO it should receive a plain dict instead of a complicated Configuration object.

@techtonik
Copy link
Contributor

👍 I don't have opinion about if it should be a dict or struct, but it should not be mixed into WSGI app class.

@chadwhitacre
Copy link
Contributor Author

Talked on #472 about this. Sounds like the driving concern is avoiding conflict between system and user configuration keys.

@chadwhitacre
Copy link
Contributor Author

This is obsolete with #527.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjz @chadwhitacre @techtonik