Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webtests #37

Open
3 of 5 tasks
teutoburg opened this issue Aug 7, 2024 · 0 comments
Open
3 of 5 tasks

Fix webtests #37

teutoburg opened this issue Aug 7, 2024 · 0 comments
Assignees
Labels
tests Related to unit or integration tests

Comments

@teutoburg
Copy link
Contributor

teutoburg commented Aug 7, 2024

The issue

Even though most of the tests in this package are not labelled as webtest, they still require a network connection if no cache is present (as it is the case in the CI). This causes occasional failures, see e.g. https://github.com/AstarVienna/speXtra/actions/runs/10289787099/job/28478293870

The cause

I attempted to run the tests locally after deleting the cache folder and disabling my internet connection, and it's not even possible to initialize the pytest session, because this already requires a download (unless cached). After "solving" this by running only the single webtest-marked test with a network connection to cache the initially required file(s), running the non-webtests without network connection is possible, but produces 42 errors, 27 failed and only 14 passed out of 83 tests.

Required actions

  • Figure out what files are actually needed to at least initialize the pytest session
  • If those are not too large, maybe keep them in the repo
  • Mark all test as webtest that actually require a network connection on an empty cache
  • Look into maybe using ScopeSim_Data for the CI runs to avoid all the downloading
  • In the long term, try to reduce the network/cache-dependency of out tests
@teutoburg teutoburg added the tests Related to unit or integration tests label Aug 7, 2024
@teutoburg teutoburg self-assigned this Aug 7, 2024
@teutoburg teutoburg moved this from 🆕 New to 📋 Backlog in ScopeSim-development Aug 7, 2024
This was referenced Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to unit or integration tests
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant