Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SynonymDb.get to use .get rather than index #32

Open
RichJackson opened this issue Jun 10, 2024 · 0 comments
Open

change SynonymDb.get to use .get rather than index #32

RichJackson opened this issue Jun 10, 2024 · 0 comments

Comments

@RichJackson
Copy link
Collaborator

SynonymDatabase.get should use a dictionary .get rather than an index, so we don't have to do this where we aren't sure if the term norm is in the db (this also happens in EmbeddingIndex.search).

However, that probably means fiddling with all the calls of .get so that mypy is happy (probably with a cast?) - this isn't massively important, so happy for this to be a backlog issue.

Original comment by @EFord36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant