From 4fd9b336c234fbb61774c29f86644d2cb90effcc Mon Sep 17 00:00:00 2001
From: Christian Clauss <cclauss@me.com>
Date: Tue, 16 Jul 2024 23:34:48 +0200
Subject: [PATCH] Windows: node: [18, 20, 22]

---
 .github/workflows/ci.yaml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 424cdd385..5d1063a0e 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -39,7 +39,7 @@ jobs:
         # ENOENT: no such file or directory, lstat 'D:\a\node-canvas\node-canvas\examples\pfennigFont\pfennigMultiByte🚀.ttf'
         # ref: https://github.com/nodejs/node/issues/48673
         # ref: https://github.com/nodejs/node/pull/50650
-        node: [18.12.0]
+        node: [18.12.0, 20, 22]
     steps:
       - uses: actions/setup-node@v4
         with:
@@ -64,7 +64,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [macos-13, macos-latest]
-        node: [20, 22]
+        node: [20, 22]  # Node 18 on macOS has node-gyp < v10 which is incompatible with Python 3.12
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/setup-node@v4
@@ -77,8 +77,6 @@ jobs:
           brew install cairo giflib jpeg libpng librsvg pango pkg-config
           pip install setuptools
       - name: Install
-        # env:
-        #  python: python3.11  # Python 3.12 requires node-gyp >= v10
         run: npm install --build-from-source
       - name: Test
         run: npm test