Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management revamp: Update single domain page #97240

Merged
merged 22 commits into from
Dec 16, 2024
Merged

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented Dec 9, 2024

Related to #96812

Proposed Changes

This PR updates the looks of the single domain overview section following the design - ePfz53j71KKDLWtuSm567A-fi-4948_7391.

There are slight deviations from the design to maintain consistency with the wordpress.com/sites screen. Please keep that in mind when comparing.

Why are these changes being made?

  • This is part of the domain management revamp project - pfuQfP-13x-p2.

Testing Instructions

  • Go to http://calypso.localhost:3000/domains/manage
  • Enable the feature flag by entering window.sessionStorage.setItem('flags', 'calypso/all-domain-management') in the - browser console. Reload the page.
  • Click on a few domains and make sure the overview is working.
  • Make sure the overview section matches the design and it looks good on mobile.

Screenshots

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Dec 9, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~24 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper                +53 B  (+0.0%)      +17 B  (+0.0%)
entry-main                   +53 B  (+0.0%)      +17 B  (+0.0%)
entry-login                  +53 B  (+0.0%)      +17 B  (+0.0%)
entry-domains-landing        +53 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~82 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +203 B  (+0.0%)      +82 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@m1r0 m1r0 self-assigned this Dec 9, 2024
@m1r0 m1r0 marked this pull request as ready for review December 9, 2024 16:04
@m1r0 m1r0 requested a review from a team as a code owner December 9, 2024 16:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2024
@m1r0 m1r0 requested a review from a team December 9, 2024 16:05
@Imran92 Imran92 linked an issue Dec 9, 2024 that may be closed by this pull request
Comment on lines 104 to 109
<span>{ itemData.subtitle }</span>
<Icon
className="sidebar-v2__external-icon"
icon={ external }
size={ extraProps?.externalIconSize || ICON_SIZE_SMALL }
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small thing I noticed, adding it here while I'm testing the rest.

As this is a common component being used in the Sites dashboard as well, I've noticed a couple of small side-effects of this change on the wordpress.com/sites screen -

  • Alignment of the external icon - not aligned with the text anymore
Before After
Screenshot 2024-12-10 at 6 37 47 AM Screenshot 2024-12-10 at 6 36 45 AM
  • External icon not at the end of the line in case of line break, also becoming smaller with screen estate instead of having a min-size
Before After
Screenshot 2024-12-10 at 6 39 12 AM Screenshot 2024-12-10 at 6 40 12 AM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! I've reverted the change and it's fixed now.

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall 🚀 Just left a couple of comments

className="sidebar-v2__external-icon"
icon={ external }
size={ extraProps?.externalIconSize || ICON_SIZE_SMALL }
/>
</Button>
) : (
itemData.subtitle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon opening domain records, the items don't have a line break, and the cards gets wide, but they aren't scrollable. So the content gets cut

My.Movie.mp4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was solved by going full-width on mobile. Could you please test it again?

padding-inline: 0;
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that in the current domain-overview screen, the accordions go full width in mobile view. But here they don't. So the starting of the right-column cards look a bit misaligned -

Existing -

Screenshot 2024-12-10 at 4 47 25 PM

New -

Screenshot 2024-12-10 at 4 48 48 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to full-width on mobile managed to solve these issues. Could you please give it another look?

image

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to full-width on mobile managed to solve these issues. Could you please give it another look?

Yap it solves the other issues. But unfortunately, I still see the issue of accordions stretching beyond the screen real estate when opened.

To make it easier to reproduce and fix, I think it happens when one of they values under the DNS records are very long. Here's how you can cause it to happen -

Screen.Recording.2024-12-12.at.1.37.45.AM.mov

@m1r0
Copy link
Member Author

m1r0 commented Dec 12, 2024

I still see the issue of accordions stretching beyond the screen real estate when opened.

This took some time to figure out but it should be fixed now!

image

@Imran92 Imran92 force-pushed the update/single-domain-page branch from b493d0b to caab7aa Compare December 13, 2024 17:10
Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue is solved! <3 Looks like it just needs a rebase and conflict fix

@m1r0 m1r0 merged commit bbba6d9 into trunk Dec 16, 2024
11 checks passed
@m1r0 m1r0 deleted the update/single-domain-page branch December 16, 2024 13:39
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 16, 2024
@a8ci18n
Copy link

a8ci18n commented Dec 16, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17065851

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @m1r0 for including a screenshot in the description! This is really helpful for our translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show single domain management overview page
4 participants