Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLean parameters for the datanode track_edit method. #2240

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

jrobinAV
Copy link
Member

@jrobinAV jrobinAV commented Nov 13, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

The PR aims to clean how the data node track edit method parameters are managed.

  • A better split between the job_id and the editor_id.
  • An explicit parameter naming so we can use constants as the edit keys.
  • Unit tests
  • Auto set the data node when an edit is added.

Related Tickets & Documents

Checklist

  • Does this PR add unit tests for the developed code? If not, why?
  • Was the documentation updated or was a dedicated issue for documentation created? (If applicable)
  • Is the release notes updated? Not applicable

@jrobinAV jrobinAV self-assigned this Nov 13, 2024
@jrobinAV jrobinAV added Core Related to Taipy Core Core: Data node labels Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19289 16774 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/data/csv.py 98% 🟢
taipy/core/data/data_node.py 99% 🟢
taipy/core/data/data_node_id.py 100% 🟢
taipy/core/data/excel.py 85% 🟢
taipy/core/data/parquet.py 97% 🟢
taipy/gui_core/_context.py 57% 🟢
TOTAL 89% 🟢

updated for commit: 0571acc by action🐍

@jrobinAV jrobinAV requested review from trgiangdo and removed request for trgiangdo November 13, 2024 13:33
taipy/core/data/csv.py Outdated Show resolved Hide resolved
taipy/core/data/data_node.py Outdated Show resolved Hide resolved
taipy/core/data/data_node.py Outdated Show resolved Hide resolved
taipy/core/data/data_node.py Outdated Show resolved Hide resolved
taipy/core/data/data_node.py Show resolved Hide resolved
@jrobinAV jrobinAV merged commit 4936044 into develop Nov 14, 2024
127 of 128 checks passed
@jrobinAV jrobinAV deleted the feature/#2017-clean-track-edit-parameters branch November 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Data node Core Related to Taipy Core 🟧 Priority: High Must be addressed as soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants