Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: merge layout for figure #2282

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2274

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Merge dark template with figure default template

Related Tickets & Documents

How to reproduce the issue

import pandas as pd
import plotly.express as px

import taipy.gui.builder as tgb
from taipy.gui import Gui

df = pd.DataFrame({"x": range(1000)})
df["y"] = df["x"] ** 3

fig = px.line(df, x="x", y="y", title="Chart title")

with tgb.Page() as page:
    tgb.toggle(theme=True)
    tgb.text("# Chart title in dark mode", mode="md")
    with tgb.layout(columns="1 1", gap="1em"):
        with tgb.part():
            tgb.chart(figure="{fig}")
        with tgb.part():
            tgb.chart("{df}", x="x", y="y", layout={"title": "Chart title"}, mode="lines")


Gui(page).run(title="2274 [🐛 BUG] Default go.Figure title position overridden to center by dark mode theme")

@FredLL-Avaiga FredLL-Avaiga added 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Nov 26, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Nov 26, 2024
Copy link
Contributor

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 3532910

Copy link
Contributor

Coverage report for ./frontend/taipy-gui

Caution

Coverage does not meet threshold
Branches coverage not met for global: expected >=80%, but got 69.45668135095447%

St.
Category Percentage Covered / Total
🟢 Statements
87.51% (+0% 🔼)
3461/3955
🟡 Branches 69.46% 2365/3405
🟢 Functions 83.22% 640/769
🟢 Lines
88% (+0% 🔼)
3204/3641

Test suite run success

698 tests passing in 47 suites.

Report generated by 🧪jest coverage report action from 3532910

Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19355 16829 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 3532910 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit f22e739 into develop Nov 26, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2274-merge-layout-for-figure branch November 26, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Default go.Figure title position overridden to center by dark mode theme
2 participants