Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selector: selection message and select all #2299

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #1834

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • selection message property dynamic(string)
  • show_select_all property boolean

Related Tickets & Documents

How to reproduce the issue

from taipy.gui import Gui, State

sel = None
sel_msg = None

def on_change(state: State, var_name: str, value):
  if var_name == "sel":
    state.sel_msg = f"{len(value)} selected elements"

page = """
<|{sel}|selector|dropdown|multiple|lov=Item 1;Item2 2;Item 3;Item 4|selection_message={sel_msg}|show_select_all|label=select an item|>
<|{sel}|selector|multiple|lov=Item 1;Item2 2;Item 3;Item 4|show_select_all|>
"""

if __name__ == "__main__":
  Gui(page).run(title="1834 Selector Dropdown Multiple Message")

show select all when multiple
resolves #1834
@FredLL-Avaiga FredLL-Avaiga added 📈 Improvement Improvement of a feature. 🖰 GUI Related to GUI 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general labels Dec 3, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 420c105

Copy link
Contributor

github-actions bot commented Dec 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19427 16906 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/gui/_renderers/factory.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 420c105 by action🐍

@FredLL-Avaiga FredLL-Avaiga changed the title selection message and select all selector: selection message and select all Dec 3, 2024
Copy link
Member

@namnguyen20999 namnguyen20999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! just a naming suggestion

taipy/gui/_renderers/factory.py Show resolved Hide resolved
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@FredLL-Avaiga FredLL-Avaiga merged commit 7b0f109 into develop Dec 3, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the feature/#1834-selector-message-select-all branch December 3, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖰 GUI Related to GUI 📈 Improvement Improvement of a feature. 🟨 Priority: Medium Not blocking but should be addressed 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add drop-down selectors with multiple values
4 participants