Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table column width should be set as minWidth to be noticed #2300

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

FredLL-Avaiga
Copy link
Member

resolves #2286

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

when specifying one column width, the style is applied but not taken into account by the table
We need to set it as min-width so that it has an impact on the table layout.

Related Tickets & Documents

How to reproduce the issue

import pandas as pd

import taipy.gui.builder as tgb
from taipy.gui import Gui

data = pd.DataFrame({"A C": [1, 2, 3], "B C": [4, 5, 6], "C C": [7, 8, 9]})

properties_table = {"width[B C]": "1000px"}

with tgb.Page() as page:
    tgb.table(data="{data}", properties="{properties_table}")

Gui(page=page).run(title="2286 [🐛 BUG] Applying width to a specific column (named with spaces) in a tgb.table does not work")

@FredLL-Avaiga FredLL-Avaiga added 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general GUI: Front-End labels Dec 3, 2024
@FredLL-Avaiga FredLL-Avaiga self-assigned this Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage report for ./frontend/taipy

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected >=80%, but got 52.07920792079208%

St.
Category Percentage Covered / Total
🔴 Statements 52.08% 263/505
🔴 Branches 21.75% 67/308
🔴 Functions 14.66% 17/116
🔴 Lines 53.42% 242/453

Test suite run success

7 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 1c7fdd2

Copy link
Contributor

github-actions bot commented Dec 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19427 16906 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 1c7fdd2 by action🐍

Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@dinhlongviolin1 dinhlongviolin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FredLL-Avaiga FredLL-Avaiga merged commit 56a0d5e into develop Dec 3, 2024
133 checks passed
@FredLL-Avaiga FredLL-Avaiga deleted the bug/#2286-table-column-width branch December 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI: Front-End 💥Malfunction Addresses an identified problem. 🟧 Priority: High Must be addressed as soon 📝Release Notes Impacts the Release Notes or the Documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 BUG] Applying width to a specific column (named with spaces) in a tgb.table does not work
3 participants