Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microsoft-sentinel-log-analytics-logstash-output-plugin hardcoded for public clouds; no national cloud support #9644

Closed
benatsb opened this issue Dec 19, 2023 · 6 comments
Assignees
Labels

Comments

@benatsb
Copy link

benatsb commented Dec 19, 2023

Hello,

The values for Azure Monitor scope and authentication endpoint of the plugin for Logstash 'microsoft-sentinel-log-analytics-logstash-output-plugin' are hardcoded for only public clouds.

Is there any updates or plan to support national cloud endpoints?

There is a related issue: #8861.

Specific code in question:
https://github.com/Azure/Azure-Sentinel/blob/72b443d59ba7d6d5d9e7d73e220d29443ab6d3d2/DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin/lib/logstash/sentinel_la/logAnalyticsAadTokenProvider.rb#L12C1-L13C1

Copy link
Contributor

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

@v-muuppugund
Copy link
Contributor

Hi @benatsb , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 25Dec2023. Thanks!

@benatsb
Copy link
Author

benatsb commented Dec 21, 2023

Adding an optional configuration parameter to the plugin to take a cloud environment option (e.g. AzureUSGovernment), then on initialization of the 'LogstashLoganalyticsOutputConfiguration' class to select the appropriate root URIs if the option was selected, otherwise give set the defaults, appears straightforward.
That could allow the change to not break current configurations as well.

I just would really love for this to be in the 'official' plugin and not have to modify and distribute our own.

@v-sudkharat
Copy link
Contributor

Hi @benatsb, we are reached out to our respective concerned team for this issue, once we get any information on this, we will update you. Thanks!

@v-sudkharat
Copy link
Contributor

v-sudkharat commented Jan 5, 2024

Hi @benatsb, As per our concern team response, currently there is no plan on including national clouds to public preview phase of the plugin. if there is any plan or update on this, the respective team update below document -
https://github.com/Azure/Azure-Sentinel/blob/72b443d59ba7d6d5d9e7d73e220d29443ab6d3d2/DataConnectors/microsoft-sentinel-log-analytics-logstash-output-plugin/README.md
So, closing this issue from GitHub. If you still need support for this issue, feel free to re-open it any time. Thank you for your co-operation.

@haim-na
Copy link
Contributor

haim-na commented Jan 30, 2024

Hello @benatsb
We recently released a new version of the plugin, version 1.1.1, which includes a OOTB support for national clouds.
Take a look on the new setting parameter named azure_cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants