fix content type bug in RecordedFuture-ThreatMap-Importer #11368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklas-recordedfuture
force-pushed
the
fix-threatmap-importer-content-type
branch
from
49a4348 to
fb8b3b6
Compare
ErikMangstenRecFut
force-pushed
the
fix-threatmap-importer-content-type
branch
from
fb8b3b6 to
637784f
Compare
niklas-recordedfuture
force-pushed
the
fix-threatmap-importer-content-type
branch
2 times, most recently
from
7878868 to
e27da1d
Compare
1. We shouldn't pass Content-Type explicitly to the API connection. This causes the reques to be sent without Content-Type (for some reason) which makes it fail. 2. Specify correct default values for the body
niklas-recordedfuture
force-pushed
the
fix-threatmap-importer-content-type
branch
from
e27da1d to
e1d8b18
Compare
niklas-recordedfuture
force-pushed
the
fix-threatmap-importer-content-type
branch
from
e1d8b18 to
37ca3dd
Compare
|
Hey @v-prasadboke, any update here? We have mostly update documentation and fixed some minor bugs. Regards, |
v-prasadboke
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change(s):
RecordedFuture-ThreatMap-ImporterContent-Typeexplicitly to the API connection. This causes the request to be sent withoutContent-Type(for some reason) which makes it fail.Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: