Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vCenter.yaml #11398

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update vCenter.yaml #11398

merged 2 commits into from
Nov 18, 2024

Conversation

schroray
Copy link
Contributor

@schroray schroray commented Nov 8, 2024

  • parse: added asterisk at the end to fix parsing

  • extend: added ClientIP field to fix workbook

    Required items, please complete

    Change(s):

    • Added asterisk at the end to fix parsing
    • Added ClientIP field to fix workbook refering to it

    Reason for Change(s):

    • Failed parsing vCenter.yaml

    Version Updated:

    • No

    Testing Completed:

    • Yes

    Checked that the validations are passing and have addressed any issues that are present:

    • Yes

- parse: added asterisk at the end to fix parsing
- extend: added ClientIP field to fix workbook
@schroray schroray requested review from a team as code owners November 8, 2024 07:12
@v-prasadboke
Copy link
Contributor

Hello @schroray, Please accept license agreement

Repackage the solution using V3
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

Update the readme located in Solution folde r

@v-atulyadav v-atulyadav added Parser Parser specialty review needed Solution Solution specialty review needed labels Nov 8, 2024
@v-prasadboke
Copy link
Contributor

Hello @schroray please accept license agreement

@schroray
Copy link
Contributor Author

@microsoft-github-policy-service agree

@v-prasadboke v-prasadboke merged commit 017271e into Azure:master Nov 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Parser Parser specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants