Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge PR #11410

Closed
wants to merge 5 commits into from
Closed

Do not merge PR #11410

wants to merge 5 commits into from

Conversation

manishkumar1991
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@manishkumar1991 manishkumar1991 requested review from a team as code owners November 11, 2024 10:25
import hashlib
import hmac
import requests
from google_auth_oauthlib.flow import InstalledAppFlow

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'InstalledAppFlow' is not used.
import hmac
import requests
from google_auth_oauthlib.flow import InstalledAppFlow
from google.auth.transport.requests import Request

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Request' is not used.
logging.info("Activity - {}, processing {} events".format(activity, len(result_activities)))
except Exception as err:
logging.error("Something wrong while getting the results. Exception error text: {}".format(err))
return result_activities, next_page_token

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error

Local variable 'next_page_token' may be used before it is initialized.
logging.info('Queue message received with body {}'.format(message_body) )
try:
result_obj, next_page_token = get_result(activity,start_time,end_time)
if (result_obj is not None) and (len(result_obj) > 0):

Check failure

Code scanning / CodeQL

Potentially uninitialized local variable Error

Local variable 'result_obj' may be used before it is initialized.
@manishkumar1991 manishkumar1991 deleted the testingnewsecrets branch November 22, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants