Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MailGuard 365 Sentinel Solution #7992

Merged
merged 24 commits into from
Sep 7, 2023
Merged

Conversation

prathikc
Copy link
Contributor

@prathikc prathikc commented May 9, 2023

Required items, please complete

Change(s):

  • MailGuard 365 Solution for Sentinel - data connector, hunting queries, workbook and logo.

Reason for Change(s):

  • New sentinel connector for MailGuard 365.

Version Updated:

  • N/A

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

- Added MailGuard 365 Logo
- Added Data Connector
- Added Hunting Queries
- Added Workbooks
@prathikc prathikc requested review from a team as code owners May 9, 2023 03:44
@prathikc
Copy link
Contributor Author

prathikc commented May 9, 2023

@microsoft-github-policy-service agree company="MailGuard Pty Ltd"

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label May 9, 2023
@prathikc prathikc changed the title Initial Commit for MailGuard 365 Sentinel Solution MailGuard 365 Sentinel Solution May 9, 2023
@v-rbajaj
Copy link
Contributor

Hi @devikamehra, please provide your feedback.

Copy link
Contributor

@devikamehra devikamehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide sample data to test Hunting queries.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented May 17, 2023

Hi @prathikc, please provide the Sample data. Also, repackage the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V2 with version 2.0.0

@v-rbajaj
Copy link
Contributor

Hi @prathikc, please address the comments from me and Devika, thanks!

  - Updated entity mappings in the query
  - Added sample data
@v-rbajaj
Copy link
Contributor

v-rbajaj commented Jun 6, 2023

Hi @prathikc, please provide the Sample data. Also, repackage the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V2 with version 2.0.0

Hi @prathikc, can you please work on this as well?

@prathikc
Copy link
Contributor Author

prathikc commented Jun 9, 2023

Hi @prathikc, please provide the Sample data. Also, repackage the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V2 with version 2.0.0

Hi @prathikc, can you please work on this as well?

Hi @v-rbajaj , I have uploaded the sample data as well now. Running into a few issues with generating the solution package, i suspect it might be with my environment, will continue to work on it.

@prathikc
Copy link
Contributor Author

prathikc commented Jun 9, 2023

Hi @v-rbajaj , I've updated the solution V2.

"sampleQueries": [
{
"description" : "All phishing threats stopped by MailGuard 365",
"query": "MailGuard365_Threats_CL \n | where where Category == \"Phishing\""
Copy link
Contributor

@v-rbajaj v-rbajaj Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra "where" from the query, this should fix the failing KQL validation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do fix the ARM TTK validation as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I've fixed the KQL validation and the ARM TTK validation as well.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 3, 2023

Hi @prathikc, thanks for making these changes.
As per latest guidelines you would repackage the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V3
Please go through the readme.md file and follow the instructions mentioned there.

Please remove the 2.0.0 zip from this PR, this PR will only have 3.0.0 zip

Please do add release note as well, follow below mentioned link for the same.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Also please fix the merge conflicts.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 8, 2023

Hi @prathikc, thanks for making these changes. As per latest guidelines you would repackage the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V3 Please go through the readme.md file and follow the instructions mentioned there.

Please remove the 2.0.0 zip from this PR, this PR will only have 3.0.0 zip

Please do add release note as well, follow below mentioned link for the same. https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Hi @prathikc, please look into this comment.
Also please fix the merge conflicts.

@v-rbajaj
Copy link
Contributor

Hi @prathikc , please look into the above comment.

@prathikc
Copy link
Contributor Author

Hi @prathikc , please look into the above comment.

@v-rbajaj Noted, will package in V3.

@v-atulyadav
Copy link
Contributor

Noted @prathikc, thanks.

@v-rbajaj
Copy link
Contributor

Hi @prathikc, can you please provide some update on this PR?

1 similar comment
@v-rbajaj
Copy link
Contributor

Hi @prathikc, can you please provide some update on this PR?

@v-rbajaj
Copy link
Contributor

Hi @prathikc, please provide some update on this PR

@prathikc
Copy link
Contributor Author

Hi @prathikc, please provide some update on this PR

Hi @v-rbajaj , i am working on packaging the solution. There are some urgent issues that I am currently working on, will provi

Hi @prathikc, please provide some update on this PR

Hi @v-rbajaj , I'm still working on the packaging, will get it ready by early next week.

@v-rbajaj
Copy link
Contributor

Hi @prathikc, thanks noted.

@v-rbajaj
Copy link
Contributor

Hi @prathikc, can you please provide some update on this PR?

@v-rbajaj
Copy link
Contributor

Hi @prathikc, thanks for making these changes, I hope you are working on adding of release notes and fixing the merge conflicts?

@prathikc
Copy link
Contributor Author

Hi @prathikc, thanks for making these changes, I hope you are working on adding of release notes and fixing the merge conflicts?

Hi @v-rbajaj , i have resolved the conflicts and have added in release notes.

"instructionSteps": [
{
"title": "Configure and connect MailGuard 365",
"description": "1. In the MailGuard 365 Console, click **Settings** on the navigation bar.\n2. Click the **Integrations** tab.\n3. Click the **Enable Microsoft Sentinel**.\n - Enter your workspace id and primary key from the fields below, click **Finish**.\n5. For additional instructions, please contact MailGuard 365 support.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prathikc, the description needs to be fixed, there is a small problem with the numbering, please take a look at image below.
image

Please repackage the solution post fixing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @v-rbajaj , that was a good catch! I have made the changes and re-packaged the solution.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Sep 5, 2023

Hi @prathikc, I just wanted to confirm if "Enter your workspace id and primary key from the fields below, click Finish." should be point 4 and "For additional instructions, please contact MailGuard 365 support." should be 5? Asking because it does look a bit odd..
image

@v-dvedak v-dvedak merged commit f78fc4d into Azure:master Sep 7, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants