Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpyCloud Enterprise Protection Initial Commit #8493

Merged
merged 87 commits into from
Sep 18, 2023

Conversation

loginsoft-integrations
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@loginsoft-integrations loginsoft-integrations requested review from a team as code owners July 11, 2023 05:45
'This alert creates an incident when an malware record is detected in the SpyCloud watchlist data'
severity: High
status: Available
queryFrequency: 12h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the - "requiredDataConnectors: []" property in both the analytic rules.
Sharing Screenshot for reference -
image

@v-sudkharat
Copy link
Contributor

Hi @RamboV, thank you for accommodating the suggested changes! We will review the Pull Request.

@v-sudkharat
Copy link
Contributor

Hi @RamboV, we added the "Release Notes" link/path in "createUiDefinition" file. please can you update or refer below shared file for existing one. also update that change in "zip" file as well. Thanks!
createUiDefinition.zip

@RamboV
Copy link
Contributor

RamboV commented Sep 13, 2023

Hi @RamboV, we added the "Release Notes" link/path in "createUiDefinition" file. please can you update or refer below shared file for existing one. also update that change in "zip" file as well. Thanks! createUiDefinition.zip

Hello @v-sudkharat it is done, please review and provide your feedback

@v-sudkharat
Copy link
Contributor

Hello @RamboV, this solution has multiple playbooks, and we are experiencing an issue while playbook deployment for few playbooks and we are checking this issue, but it will take some time to fix. we will update you on this, once this issue fix. Thanks

@RamboV
Copy link
Contributor

RamboV commented Sep 16, 2023

Hello @v-sudkharat made changes accordingly kindly review

Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. Solution content type Created and Tested successfully.
Below is a screenshot of deployed and created content type: -
Dashboard

Thanks!

@v-atulyadav v-atulyadav merged commit c5886fc into Azure:master Sep 18, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants