Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZeroFox Solution #8661

Merged
merged 25 commits into from
Sep 18, 2023
Merged

ZeroFox Solution #8661

merged 25 commits into from
Sep 18, 2023

Conversation

DNRRomero
Copy link
Contributor

Required items, please complete

Change(s):

  • Add ZeroFox Data connectors into the ZeroFox API and CTI feeds as Solutions

Reason for Change(s):

  • Provides an Integration of Sentinel with ZeroFox by way of a marketplace solution

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need help

figarrido and others added 5 commits July 24, 2023 12:22
It also adds analytic rules to map ZeroFox alerts
to Microsoft Sentinel Incidents based on severity.
Adds all ZeroFox connectors to CTI feeds by way of Azure Functions, as per task
ZFE-73125
Adds configuration info for CTI connectors according to ZF-73126
…ctions

* Add configuration file ZeroFox_CTI_FunctionApp.json for azure functions
* Add unit test for ZeroFox Client
* Move Data Connectors from connectors folder

According to task ZFE-73126
Add Data folder and solution metadata file as per task ZF-7126
@DNRRomero DNRRomero requested review from a team as code owners July 28, 2023 16:22
@DNRRomero
Copy link
Contributor Author

@microsoft-github-policy-service agree company="ZeroFox"

@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Jul 31, 2023
* Add fixes shown by Azure's CI pipeline

* Add custom log schemas for CTI data connectors

* Add custom table specifications for CTI tables

Table description specifications added:

- Identity breach

- IRC

- Malware

- National IDs

- Phishing

- Phone Numbers

- Ransomware

- Telegram

- Threat Actors

- Vulnerabilities

* Fix comments

* Fix types on custom tables schemas

---------

Co-authored-by: Diego Ramirez <dramirez@zerofox.com>
Co-authored-by: Felipe Garrido <fgarridob.95+github@gmail.com>
@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 1, 2023

Hi @DNRRomero, thanks for raising this PR, we will review and provide an update by 4 Aug 2023

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 4, 2023

Hi @DNRRomero,
Please add the missing files in data connector folder according to these files
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Bitglass/Data%20Connectors

For example: the zip file, azuredeploy file, host file, requirements etc are missing, please add them.

Then package the solution using this tool https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Create-Azure-Sentinel-Solution/V3
Please go through the readme.md file and follow the instructions mentioned there.

Please do add release note as well, follow below mentioned link for the same.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Add release notes, versioning files in Package folder, as well as template fails from ARM toolkit
@DNRRomero
Copy link
Contributor Author

Hi @v-rbajaj , we added the missing files, which where the release notes and package folder. As for the rest you mentioned, they are located in the CTI subfolder of Data Connectors.
Also, could you help us with the CI pipeline errors? the KqlValidations step is throwing an error which we have not been able to identify and it would be great to hear what you think on it

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 7, 2023

Hi @DNRRomero, we are checking the KQL validation failure, we will provide you an update by 9 Aug 2023

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 9, 2023

We are still checking on the KQL validation failure, will update you by 11 Aug 2023

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, Please add these two lines in properties of .script/tests/KqlvalidationsTests/CustomTables/ZeroFox_CTI_national_ids_CL.json


"name": "TimeGenerated",
"type": "DateTime"

@v-atulyadav
Copy link
Contributor

Hi @DNRRomero,
Thank you for accommodating the suggested changes! We will review the Pull Request and get back to you by 16 Aug 2023.

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, we are investigating on both the failures, sorry for the delay, will get back to you by 18 Aug 2023.

@DNRRomero
Copy link
Contributor Author

@v-rbajaj I always able to fix the pipeline, there was a problem in the mainTemplaje.json file

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, we will check the ARM TTK validation and provide you an update by 23 Aug 2023

@DNRRomero
Copy link
Contributor Author

Hello @v-rbajaj I fixed the arm-ttk validation step

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Aug 22, 2023

Hi @DNRRomero,I also deployed maintemplate, but for some reason the contents are not visible, need to check on this issue, will get back by 24 Aug 2023.
image

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, seems like the maintemplate does not have any contents like Data connectors, analytical rules. Request you repackage the solution and push the changes.

If ARM ttk validation fails, we will take care of it.

Please make the suggested changes.

@DNRRomero
Copy link
Contributor Author

Hello @v-rbajaj I repackaged the solution and fixed the arm-ttk validation

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, thanks for making these changes, I can now see the contents post deployment of maintemplate.

I am ingesting data to check and verify the contents. Ill get back to you by 30 Aug 2023.

"Logo": "<img src=\"https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Logos/foxy-mark.svg\" width=\"75px\" height=\"75px\">",
"Description": "The [ZeroFox](https://www.zerofox.com/) solution for Microsoft Sentinel enables you to ingest [ZeroFox Alerts](https://www.zerofox.com/platform/) and [ZeroFox CTI events]](https://www.zerofox.com/threat-intelligence/) into Microsoft Sentinel using the ZeroFox API. \n\n**Underlying Microsoft Technologies used:**\n\nThis solution takes a dependency on the following technologies, and some of these dependencies either may be in [Preview](https://azure.microsoft.com/support/legal/preview-supplemental-terms/) state or might result in additional ingestion or operational costs:\n\na. [Azure Monitor HTTP Data Collector API](https://docs.microsoft.com/azure/azure-monitor/logs/data-collector-api)\n\nb. [Azure Functions](https://azure.microsoft.com/services/functions/#overview)",
"Data Connectors": [
"Data Connectors/CTI/ZeroFox_API_FunctionApp.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file ZeroFox_API_FunctionApp.json doesn't exist in this folder.

I think you were trying to refer ZeroFox_CTI_FunctionApp.json, if yes, then please update the name here and repackage the solution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @v-rbajaj , the file has been fixed, and the solution repackaged

Co-authored-by: Diego Ramirez <dramirez@zerofox.com>
@v-rbajaj
Copy link
Contributor

v-rbajaj commented Sep 1, 2023

Hi @DNRRomero, all the analytical rules are missing tactics and relevanttechniques, please add them.

Refer : - https://github.com/Azure/Azure-Sentinel/wiki/Query-Style-Guide#tactics

We would need to repackage the solution.

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Sep 5, 2023

Hi @DNRRomero, can you please provide some update on the above comment?

@DNRRomero
Copy link
Contributor Author

Hello @v-rbajaj , I have just added the changes you requested, could you take a look?

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Sep 7, 2023

Hi @DNRRomero, you would need to update this branch from master for the validations to run.

@DNRRomero
Copy link
Contributor Author

Hi @v-rbajaj , I updated the branch with respect to master

@v-rbajaj
Copy link
Contributor

Hi @DNRRomero, we will provide you an update by 15 Sep 2023.

@v-atulyadav v-atulyadav merged commit da97c45 into Azure:master Sep 18, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants