Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASIM Registry Event schema parser with its sample and test data for Trend Micro Vision One #8680

Merged
merged 24 commits into from
Dec 6, 2023
Merged

ASIM Registry Event schema parser with its sample and test data for Trend Micro Vision One #8680

merged 24 commits into from
Dec 6, 2023

Conversation

jayeshprajapaticrest
Copy link
Contributor

Required items, please complete

Change(s):

  • Added ASIM Registry Event schema parser for Trend Micro Vision One based on API Data

Reason for Change(s):

  • Initial version ASIM Registry Event Parser

Version Updated:

  • Initial version

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@jayeshprajapaticrest jayeshprajapaticrest requested review from a team as code owners July 31, 2023 13:01
@v-sudkharat
Copy link
Contributor

Hello @jayeshprajapaticrest, thank you for raising Pull Request with us! We will review it internally and get back to you shortly.

@v-sudkharat
Copy link
Contributor

Hi @jayeshprajapaticrest, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries or support. Thanks!

@v-rusraut
Copy link
Contributor

Hi @jayeshprajapaticrest,
Please work on above comment to resolve KqlValidations issue.
Thanks.

@vakohl
Copy link
Contributor

vakohl commented Aug 12, 2023

ETA: review by 21 Aug

@jayeshprajapaticrest
Copy link
Contributor Author

Hi @jayeshprajapaticrest, Please work on above comment to resolve KqlValidations issue. Thanks.

@v-rusraut Sorry for being late reply. Will looking into it and update here once done. Thanks

@v-rusraut
Copy link
Contributor

Noted @jayeshprajapaticrest,
Thanks

@keyur-cds
Copy link

@v-sudkharat @v-rusraut - all comments and validations are resolved. can you please help with your review?

@v-rbajaj
Copy link
Contributor

v-rbajaj commented Sep 8, 2023

Hi @keyur-cds, we acknowledge your message.

vakohl
vakohl requested changes Sep 24, 2023
View reviewed changes
Parsers/ASimRegistryEvent/Parsers/imRegistry.yaml Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/Parsers/imRegistry.yaml Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/Parsers/vimRegistryEventTrendMicroVisionOne.yaml Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/test/TrendMicro_VisionOne_vimRegistryEvent_DataTest.csv Show resolved Hide resolved
Parsers/ASimRegistryEvent/test/TrendMicro_VisionOne_vimRegistryEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/test/TrendMicro_VisionOne_vimRegistryEvent_SchemaTest.csv Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/test/TrendMicro_VisionOne_vimRegistryEvent_DataTest.csv Show resolved Hide resolved
Parsers/ASimRegistryEvent/Parsers/vimRegistryEventTrendMicroVisionOne.yaml Outdated Show resolved Hide resolved
Parsers/ASimRegistryEvent/Parsers/vimRegistryEventTrendMicroVisionOne.yaml Outdated Show resolved Hide resolved
@v-atulyadav
Copy link
Contributor

Hi @jayeshprajapaticrest, please provide your updates on @vakohl's comments. Thanks

@keyur-cds
Copy link

@v-atulyadav Sure we will look into it and will update in couple of days.

@niralishah-crest niralishah-crest requested review from a team as code owners November 23, 2023 12:23
@v-rbajaj
Copy link
Contributor

Hi @niralishah-crest, the merge conflicts haven't resolved, I hope you are still looking into it.

@niralishah-crest
Copy link
Contributor

Hi @niralishah-crest, the merge conflicts haven't resolved, I hope you are still looking into it.

@v-rbajaj Merge conflicts are resolved now.

@niralishah-crest
Copy link
Contributor

Hello @jayeshprajapaticrest, Please respond to the above comments.

@v-prasadboke @vakohl comments are addressed and merge conflicts are resolved

@v-rbajaj
Copy link
Contributor

Hi @niralishah-crest, thanks for the update.

@vakohl
Copy link
Contributor

vakohl commented Nov 30, 2023

@jayeshprajapaticrest @niralishah-crest
there are unwanted changes included in this PR, can you please remove them?

@vakohl
Copy link
Contributor

vakohl commented Dec 4, 2023

@jayeshprajapaticrest @niralishah-crest there are unwanted changes included in this PR, can you please remove them?

@jayeshprajapaticrest @niralishah-crest
There are unrelated changes included in this PR. Please remove them. Also please have a look at the merge conflicts

@niralishah-crest
Copy link
Contributor

@jayeshprajapaticrest @niralishah-crest there are unwanted changes included in this PR, can you please remove them?

@jayeshprajapaticrest @niralishah-crest There are unrelated changes included in this PR. Please remove them. Also please have a look at the merge conflicts

@vakohl Unrelated changes are removed from this PR. Also merge conflicts are resolved.
Thanks.

@v-atulyadav
Copy link
Contributor

Thanks @niralishah-crest.

vakohl
vakohl previously approved these changes Dec 6, 2023
View reviewed changes
@v-atulyadav v-atulyadav merged commit c15a292 into Azure:master Dec 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-sudkharat v-sudkharat v-sudkharat left review comments

@niralishah-crest niralishah-crest niralishah-crest left review comments

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@vakohl vakohl vakohl left review comments

Assignees

@vakohl vakohl

@v-rbajaj v-rbajaj

@v-sudkharat v-sudkharat

Labels
ASIM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jayeshprajapaticrest @v-sudkharat @v-rusraut @vakohl @keyur-cds @v-rbajaj @v-atulyadav @niralishah-crest @v-prasadboke