Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct exchange environment list parser in Workbook to match the name in the solution #8841

Merged

Conversation

nlepagnez
Copy link
Contributor

Change(s):

  • Change the parser in all Workbooks to be "ExchangeEnvironmentList"

Reason for Change(s):

  • The name of the parser created by the solution was not the same that the one used in Workbooks

@nlepagnez nlepagnez requested review from a team as code owners August 21, 2023 14:01
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 21, 2023
@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Thank you for raising this PR. This PR will be investigated and and will update you before 24 August, 2023.

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Please repackage all the solutions with V3 tool with Version 3.0.0.
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

Also please add release notes to the solutions as well.
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

@nlepagnez
Copy link
Contributor Author

Hello @nlepagnez, Thank you for raising this PR. This PR will be investigated and and will update you before 24 August, 2023.

Hi @v-prasadboke, Package was rebuilt in V3 as requested.

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Thank you for committing the changes. We will examine this PR and will update you about the same before 29 August, 2023.

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Please replace the parsers mentioned in input file with .yaml extension which are currently in .txt format.
After making this changes please repackage the solution again with V3.
Also please share the sample data to test the content of these two solutions.
Thanks.

@nlepagnez
Copy link
Contributor Author

The solution is updated as requested. The sample data are already here. I updated the dates for you.

Please, it's a bug on the current deployed solution that block the usage of wokbooks due to a wrong publication. Can you be efficient on your analysis and stop to ask 1 thing each 3 days.

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Aug 31, 2023

Hello @nlepagnez, Sorry for the inconvenience you have faced. But the format change of parser from .txt to .yaml was implemented few days ago, Thats the reason I asked you to repackage the solution again.

I custom deployed the maintemplate but due to lack of sample data I was unable to test the content of the solution.
As you have uploaded the sample data I'll continue with my testing and update you about the same before 4 September, 2023.

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Sample data for table ESIAPIexchange is missing, could you please upload the same

@nlepagnez
Copy link
Contributor Author

Hello @nlepagnez, Sample data for table ESIAPIexchange is missing, could you please upload the same

@v-prasadboke, the "ESI-ExchangeOnPremisesCollector-SampleData.json" file is the sample file for ESIAPIExchange and ESIAPIExchangeOnline tables since the beginning. So please again, it's un urgency as the published solution doesn't works today this creates a lot of frustration.

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Sep 5, 2023

Hello @nlepagnez, Can we schedule a call as most of the parsers are not working as expected might be due to irrelevant Sample data.
I work in IST time zone and usually available between 2:00 PM to 7:00 PM IST.
If possible can we connect today or tomorrow, Please let us know and share your email-id as well.
Thanks.

@v-atulyadav v-atulyadav merged commit 45f9318 into Azure:master Sep 7, 2023
29 checks passed
@nlepagnez nlepagnez deleted the Correct-ExchangeEnvironmentList-parser branch September 7, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants