Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infoblox 3.0.0 etc #8889

Merged
merged 9 commits into from
Sep 4, 2023
Merged

Infoblox 3.0.0 etc #8889

merged 9 commits into from
Sep 4, 2023

Conversation

sschuur
Copy link
Contributor

@sschuur sschuur commented Aug 28, 2023

Change(s):

  • Couple more necessity changes for #8343. Updated parser links to new .yaml. Couple UI fixes. Added description for workbook.

Version Updated:

@sschuur sschuur requested review from a team as code owners August 28, 2023 07:41
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 28, 2023
@v-prasadboke
Copy link
Contributor

Hello @sschuur, Thanks for raising the PR. This will be investigated and will update you about the same before 30 August, 2023.

v-prasadboke
v-prasadboke previously approved these changes Aug 29, 2023
@v-prasadboke v-prasadboke dismissed their stale review August 29, 2023 08:41

Mistakenly approved

@v-prasadboke
Copy link
Contributor

Hello @sschuur, Please resolve the arm ttk failure by incrementing the version of analytic rules mentioned in this PR.
Thanks.

@sschuur
Copy link
Contributor Author

sschuur commented Aug 29, 2023

Hi @v-prasadboke i incremented the versions in the .yamls to 1.0.1.

@v-prasadboke
Copy link
Contributor

Hello @sschuur, Please repackage the solution again so that the modified changes in detection's would reflect in maintemplate

@sschuur
Copy link
Contributor Author

sschuur commented Aug 30, 2023

Hi @v-prasadboke whoops sorry incremented the versions in maintemplate. Also updated the data connector instructs and added that to maintemplate too. tiny fix.

Quick question: how do i get the workbook to appear as Related Content when looking at the data connector?

Thank you!

image

@v-prasadboke
Copy link
Contributor

Hello @sschuur, Thank you for committing the requested changes.
Will examine the changes and update you about the same before 1 September, 2023.

And will update you too about the query you mentioned. But I was going through data connectors on Portal, Same case is happening with other connector to.
We will get back to you about this issue.
Thanks.

v-prasadboke
v-prasadboke previously approved these changes Sep 1, 2023
@v-atulyadav v-atulyadav merged commit e443d72 into Azure:master Sep 4, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants